Ensure unspecified params are nil, not an empty string#35
Closed
mistydemeo wants to merge 1 commit intomasterfrom
Closed
Ensure unspecified params are nil, not an empty string#35mistydemeo wants to merge 1 commit intomasterfrom
mistydemeo wants to merge 1 commit intomasterfrom
Conversation
mistydemeo
force-pushed
the
ensure_unspecified_params_are_nil
branch
from
ff224d5 to
118e7f0
Compare
Contributor
Author
|
Based on the discussion in rails/rails#31845, it appears that this is a newly-introduced issue in Rails's controller testing. It's being fixed upstream, so I'm going to close this with the understanding that chatops-controller based tests will act unexpectedly in current versions of Rails 5.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression we noticed in Rails 5. Unspecified matched regex values were being returned as empty strings, not nil; this broke chatops-controller apps which did truthiness and nil checks against their parameters. I tested this new test against both Rails 4 and 5; should be compatible with both.