Add support for "attachment" feature#37
Merged
mistydemeo merged 2 commits intomasterfrom Jun 26, 2018
Merged
Conversation
This adds support for a new option, which allows servers to hint to clients that they should format the response as a separate attachment instead of returning it inline as a message. Because this is a hint, and because not all clients will support an attachment mode, clients are allowed to ignore this field for any reason. For example, Slack supports "snippets", which are arbitrary text documents sent as attachments. These don't use Slack's normal message formatting and have a larger filesize limit.
mattr-
approved these changes
Jun 25, 2018
|
@github/security-ops will be very happy to see this. We have a number of ChatOps that currently get cut off because slack is unfurling URLs which throws off the character count. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for a new option, which allows servers to hint to clients that they should format the response as a separate attachment instead of returning it inline as a message. Because this is a hint, and because not all clients will support an attachment mode, clients are allowed to ignore this field for any reason.
For example, Slack supports "snippets", which are arbitrary text documents sent as attachments. These don't use Slack's normal message formatting and have a larger filesize limit.
cc @kpaulisse, who requested this feature.