Conversation
| metadata | ||
| } | ||
| matcher = matchers.first { |matcher| matcher["regex"].match(message) } | ||
| matcher = matchers.find { |matcher| matcher["regex"].match(message) } |
Contributor
There was a problem hiding this comment.
Are both of these supposed to be here?
Contributor
Author
There was a problem hiding this comment.
Are both of these supposed to be here?
Nope, fixed. Thanks.
Contributor
|
Fairly quirky implementation as you mentioned, but I dig the result. |
Contributor
Author
|
This is working great over in https://github.com/github/heaven/pull/2597, better than I hoped! I don't think testing could be more intuitive. I will land this when that branch lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up on CI: How do we test some of these regexes?
This gives us a new test helper,
chat, that actually parses a chat message, matches it against parsed regexes, turns it into parameters, and lets us compare that everything's fine.cc @jakedouglas, who mentioned this on the CI pull https://github.com/github/ci/pull/1013