Support multiline chatop pattern matching#49
Closed
laserlemon wants to merge 2 commits intomasterfrom
Closed
Conversation
anglinb
approved these changes
Jun 6, 2019
Contributor
anglinb
left a comment
anglinb
left a comment
There was a problem hiding this comment.
👋 @laserlemon I must have missed this but I was just about to open issue to support multiline chatops 😉 I would love this for some of the stuff I'm working on. The implementation looks good to me! @mistydemeo anything we need to do to get a 👍 on this?
|
Also coming here to give this a friendly nudge, as this would greatly help our chatop accept a multi-line backtrace! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test added is actually a decent example of how multiline chatop matching could be useful. My intended use is a command to complement a suite of existing commands that manage a list of terms. The new command would allow the entire dictionary of terms to be replaced in one fell swoop. For example: