Skip to content

Update minimum Git version for overlay to 2.36.0#3781

Merged
henrymercer merged 2 commits intomainfrom
henrymercer/update-git-minimum-version
Mar 27, 2026
Merged

Update minimum Git version for overlay to 2.36.0#3781
henrymercer merged 2 commits intomainfrom
henrymercer/update-git-minimum-version

Conversation

@henrymercer
Copy link
Copy Markdown
Contributor

@henrymercer henrymercer commented Mar 27, 2026

The git ls-files --recurse-submodules option was introduced in Git 2.11.0, but it is only compatible with --stage since Git 2.36.0. The --cache option is supported earlier, but doesn't include the OIDs in the output.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner March 27, 2026 14:04
Copilot AI review requested due to automatic review settings March 27, 2026 14:04
@github-actions github-actions bot added the size/XS Should be very easy to review label Mar 27, 2026
@henrymercer henrymercer added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit d6d1743 Mar 27, 2026
229 of 230 checks passed
@henrymercer henrymercer deleted the henrymercer/update-git-minimum-version branch March 27, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants