Revert "C++: Accept test changes after github/codeql#21313."#1041
Open
paldepind wants to merge 1 commit intogithub:nextfrom
Open
Revert "C++: Accept test changes after github/codeql#21313."#1041paldepind wants to merge 1 commit intogithub:nextfrom
paldepind wants to merge 1 commit intogithub:nextfrom
Conversation
This reverts commit 141d5be.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts earlier INT34-C unit test accommodations that marked some cases as expected false positives due to range analysis precision reduction. With the upstream change in SimpleRangeAnalysis (github/codeql#21329), the range bounds for these shift-count expressions no longer “blow up,” so the original test expectations can be restored.
Changes:
- Update
INT34-CC test annotations to removeCOMPLIANT[FALSE_POSITIVE]markers for two shift cases that are now correctly analyzed. - Refresh the corresponding
.expectedresults to reflect tighter computed upper bounds (e.g., 64/63 instead of 127) and the resulting alert set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
c/cert/test/rules/INT34-C/test.c |
Removes false-positive compliance tags for two shift expressions now handled precisely. |
c/cert/test/rules/INT34-C/ExprShiftedbyNegativeOrGreaterPrecisionOperand.expected |
Updates expected diagnostics to match improved range bounds and resulting findings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the test changes made in #1036. With the change in github/codeql#21329 the number of bounds estimate now handles this file without the number of bounds blowing up.