TS: fix analysis of export= and default imports #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript statement
export = Xcompiles tomodule.exports = Xor equivalent. It can therefore be imported using a non-standard default import. Our handling of non-standard default imports rely on recognizing that an ES2015 module is importing a CommonJS/AMD module, and didn't take this case into account.TypeScript has a flag
--esModuleInteropwhich makes default imports behave as namespace imports if the target module is not an ES2015 module, and for this purpose, having anexport =assignment counts as not being an ES2015 module.Fixes #1266