Skip to content

Sync go libraries #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Nov 30, 2022
Merged

Sync go libraries #11481

merged 22 commits into from
Nov 30, 2022

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Nov 29, 2022

This builds on #11002 and brings the go copy of the data flow libraries up to date (at the time of writing). All the changes look uneventful.

@owen-mc owen-mc requested a review from a team as a code owner November 29, 2022 14:15
@owen-mc owen-mc force-pushed the dataflow/sync-go-libraries-2 branch from 7a97d8f to 94e6f4b Compare November 29, 2022 14:18
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Private changes look plausible except as noted.

Suggest a DCA for confidence in the results.

@owen-mc owen-mc force-pushed the dataflow/sync-go-libraries-2 branch from 94e6f4b to 0343e21 Compare November 29, 2022 16:14
@owen-mc owen-mc force-pushed the dataflow/sync-go-libraries-2 branch from 0343e21 to 083a3ba Compare November 29, 2022 16:15
@owen-mc owen-mc merged commit ab276fc into github:main Nov 30, 2022
@owen-mc owen-mc deleted the dataflow/sync-go-libraries-2 branch November 30, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants