Fix/jwt source #16141
Open
Fix/jwt source #16141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider this code:
```java
JwtParserBuilder parserBuilder = Jwts.parserBuilder();
parserBuilder.setSigningKey("someBase64EncodedKey");
JwtParser parser = parserBuilder.build();
return parser;
```
Previously `setSigningKey` (the method access) was considered the source.
However the return value of that call does not flow anywhere, the method
changes the qualifier instead. So this commit changes the source to the
qualifier instead.
|
@smowton @atorralba ping? |
atorralba
reviewed
Apr 16, 2024
| m.getDeclaringType().getAnAncestor() instanceof TypeJwtParserBuilder | ||
| | | ||
| this.asExpr() = ma and | ||
| this.asExpr() = ma.getQualifier() and |
There was a problem hiding this comment.
We should keep the return value as well, since the call to setSigningKey returns the parser/builder:
Suggested change
| this.asExpr() = ma.getQualifier() and | |
| this.asExpr() = [ma, ma.getQualifier()] and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this code:
Previously
setSigningKey(the method access) was considered the source.However the return value of that call does not flow anywhere, the method
changes the qualifier instead. So this commit changes the source to the
qualifier instead.
NOTE:
I inlined all the
good/badmethods, because otherwise I could not differentiate between the different sources.This is probably an artifact of the changes in bc2370a by @atorralba
I'd guess that there is probably a way to avoid the inlining, but I'd really like to spend as little time on this pr as possible.
(I just want to take this problem off my mind after knowing about if for probably more than half a year^^)