JS: Remove special treatment of strings in AngularJS code #20360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String literals are already SourceNodes. But we need to add template literals as well
asgerf
force-pushed
the
js/remove-angularjs-string-special-case
branch
from
b563681 to
5b0ef40
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes special handling for string literals in AngularJS code by eliminating a custom TrackStringsInAngularCode class that was redundant since string literals were already tracked as SourceNodes. The change ensures template literals are properly treated as source nodes across all JavaScript code.
- Removes the
TrackStringsInAngularCodeclass and associated helper predicates from AngularJS core - Adds
TemplateLiteralto the mainSourceNode::Rangeimplementation to ensure consistent tracking - Updates test expectations to reflect template literals now being properly recognized as source nodes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/lib/semmle/javascript/frameworks/AngularJS/AngularJSCore.qll | Removes custom string tracking class and helper predicates that were redundant |
| javascript/ql/lib/semmle/javascript/dataflow/Sources.qll | Adds TemplateLiteral to the main SourceNode implementation |
| javascript/ql/test/library-tests/DataFlow/tests.expected | Updates test expectations to include template literals as tracked source nodes |
Contributor
Author
|
The failures in DCA are due to a problem with SARIF exports that is not related to this PR |
Napalys
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a dependency that is problematic for overlay locality. String literals were in fact already SourceNodes so this was mostly redundant. but we do need to treat template literals as SourceNodes as well