Go: Support git_source
#20368
Merged
Go: Support git_source
#20368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for git_source type registry configurations in the Go extractor's proxy handling functionality. The change extends the existing registry proxy system to handle Git sources alongside the existing goproxy server support.
- Adds
git_sourcetype support to registry configurations - Updates proxy environment variable handling to process Git sources
- Adds comprehensive test coverage for multiple registry configurations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/extractor/util/registryproxy.go | Adds git_source constant, refactors data structures to separate goproxy servers and Git sources, and updates environment variable handling logic |
| go/extractor/util/registryproxy_test.go | Adds new test function to verify parsing of multiple registry configurations including both git_source and goproxy_server types |
mbg
force-pushed
the
mbg/go/support-git-source
branch
4 times, most recently
from
82f29ab to
baad5dd
Compare
mbg
force-pushed
the
mbg/go/support-git-source
branch
2 times, most recently
from
7be30e2 to
0ffc9fc
Compare
Since `GOPRIVATE` / `GONOPROXY` expect a glob pattern
mbg
force-pushed
the
mbg/go/support-git-source
branch
from
0ffc9fc to
8c84992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the Go autobuilder/extractor to support
git_sourceprivate registry configurations, in addition to thegoproxy_serverconfigurations that were already supported.In github/codeql-action#3079, we modified the CodeQL Action so that
git_sourceconfigurations are now propagated to the Go autobuilder/extractor.With the changes in this PR, if a
git_sourceconfiguration is provided, we setGOPRIVATEto include a pattern for the hostname provided in the configuration. TheGOPRIVATEvariable instructsgowhich packages should not be fetched via aGOPROXY(whether it's the default one or a custom one). For example, if thegit_sourceconfiguration is forhttps://github.com/foo, then we'd setGOPRIVATE=github.com/foo*.This is a simplification of what is necessary for
GOPRIVATE, because Go modules may not have the same name as the address of the repository that contains them. Ideally, we would makeGOPRIVATEconfigurable somehow, possibly using ago.envfile in the repository or similar. However, for initially supporting this, the behaviour here should be sufficient.If a
git_sourceis configured, we also configuregiton the runner to use the self-signed proxy certificate. Otherwise, it will refuse to connect.