Rust: add rust-analyzer update instructions
#20404
Conversation
geoffw0
added
no-change-note-required
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive documentation for updating rust-analyzer dependencies in the Rust CodeQL implementation. The changes provide step-by-step instructions for maintaining rust-analyzer and related dependencies, including toolchain updates and schema migrations.
- Adds a detailed section on rust-analyzer update procedures
- Includes instructions for dependency management, bazel file regeneration, and toolchain updates
- Documents the complete workflow from upgrade to testing and schema migration
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
redsun82
left a comment
redsun82
left a comment
There was a problem hiding this comment.
LGTM, apart from a minor oversight coming from me 🙂
|
The CI failures should go away with the merge from main I just did |
Co-authored-by: Simon Friis Vindum <paldepind@github.com>
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Looks good to me. Instructions are clear and easy to follow. Thanks @geoffw0 and @redsun82.
One thought going forward, in #20408 I ran into a problem because the first cargo upgrade also applies to ruby/extractor/Cargo.toml and that broke the Ruby extractor. I guess it would be preferable if we could update RA for the Rust extractor without affecting the Ruby extractor.
Fair point, although it is a nice side effect that the Ruby extractor is kept up to date as well. |
|
Merging - but I'm happy to make further changes to these instructions if there are more suggestions. |
4 participants
First commit (most of the work) is taken from closed PR #19930 by @redsun82 .
I hope to add a few more details before this is ready to merge.