Rust: Fix a minor issue with the test for rust/request-forgery #20441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
added
no-change-note-required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the test for rust/request-forgery by adding model preprocessing to ensure stable test output. The change prevents frequent changes to .expected results by preprocessing models-as-data IDs before testing.
- Added a preprocessing step for models to convert raw IDs to stable format
- Updated the test configuration to include pretty printing for models
- Regenerated expected test results with stable model IDs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| RequestForgery.qlref | Added PrettyPrintModels.ql preprocessing step to stabilize model IDs |
| RequestForgery.expected | Updated test expectations with stable model IDs (MaD:1, MaD:2, MaD:3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a minor issue with the test for
rust/request-forgery. The models-as-data IDs were being output raw which tends to cause issues with the.expectedresults changing frequently.