JS: remove quality tag from SyntaxError query #20644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the "quality" tag from the JavaScript SyntaxError query, keeping only the "reliability", "correctness", and "language-features" tags. This change results in the query being excluded from JavaScript code quality test suites.
- Removed "quality" tag from SyntaxError.ql query metadata
- Updated query suite expectations to reflect the removal from quality-focused test suites
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/src/LanguageFeatures/SyntaxError.ql | Removed "quality" tag from query metadata tags list |
| javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected | Removed SyntaxError.ql from expected code quality suite results |
| javascript/ql/integration-tests/query-suite/javascript-code-quality-extended.qls.expected | Removed SyntaxError.ql from expected extended code quality suite results |
asgerf
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the SyntaxError query from the
qualityandquality-extendedsuites, while it remains in thesecurity-and-qualitysuite.