Rust: Improve macro call stats in DatabaseQualityDiagnostics #20648
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acted files (.fromSource). This is already the case in other places we measure this.
There was a problem hiding this comment.
Pull Request Overview
This PR improves the macro call statistics in DatabaseQualityDiagnostics by restricting the analysis to only consider macros in extracted source files (using .fromSource()). This change focuses the metric on user code rather than including all macro calls, aligning with existing measurement approaches in other diagnostic queries.
Key changes:
- Modified macro call statistics to only count macros from source files
- Applied the
.fromSource()filter to both successful and failed macro expansion counts
|
DCA LGTM. Two diagnostics issues are fixed there. |
|
Put back to draft - I think we can do better now using the new tools in #20655 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict the macro call stats in
DatabaseQualityDiagnostics(used on the tool status page) to consider only macros in extracted files (.fromSource()). This focusses the metric on the user code for analysis, and is already the way we measure this inrust/diagnostics/unresolved-macro-callsandrust/summary/summary-statistics.In the MRVA-1000, this change will reduce the number of projects with warnings about macro resolution on the tool status page from 30 to 16 (21 fixed, 9 unfixed, 7 newly failing), and significantly improves the margin of success in many more projects where we don't believe there is a real problem.