Swift: Do not include the embedded resources #20710
Conversation
| category: majorAnalysis | ||
| --- | ||
| * Upgraded to allow analysis of Swift 6.2. | ||
| * Support for experimental Embedded Swift has been dropped. |
There was a problem hiding this comment.
Was it actually present / do we know if it worked in previous releases?
There was a problem hiding this comment.
It was present. If it actually worked, I don't know. It's not something we ever tested for.
Happy to run QA, but that will take a few days. |
|
I'm happy with DCA provided we're confident its a meaningful test. I'm not too sure where the failure was observed. |
I think it should give some good insight as to whether non-embedded Swift projects still work.
The reason for changing this, is because we went over the maximum bundle size of 2GB due to the Swift upgrade, and looking at the resources this seemed an obvious target given the experimental status of Embedded Swift. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates Swift resource bundles and documentation to drop support for experimental Embedded Swift. The macOS resource file size is reduced significantly (from ~816MB to ~614MB), while the Linux resource file is also updated.
- Updated Swift resource bundles for both macOS and Linux platforms
- Added documentation clarifying that Embedded Swift is not supported
- Updated change notes to document the dropping of experimental Embedded Swift support
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| swift/third_party/resources/resource-dir-macos.zip | Updated macOS Swift resource bundle with reduced size (~200MB smaller) |
| swift/third_party/resources/resource-dir-linux.zip | Updated Linux Swift resource bundle SHA256 hash |
| swift/ql/lib/change-notes/2025-10-22-swift-6.2.md | Added note about dropping Embedded Swift support |
| docs/codeql/reusables/supported-versions-compilers.rst | Added footnote clarifying Embedded Swift is not supported |
| docs/codeql/codeql-overview/system-requirements.rst | Added explicit requirement that Swift extraction requires macOS |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
For testing we want to look at the nightly build whether it manages to publish the all platform bundle. |
3 participants
No description provided.