-
Notifications
You must be signed in to change notification settings - Fork 1.8k
CI: update images in build-ripunzip.yml
#20800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the GitHub Actions workflow to use the newer macOS 15 runner for building ripunzip binaries.
- Updates the macOS runner from
macos-13tomacos-15in the build matrix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
macos-13 imagebuild-ripunzip.yml
esbena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But it needs some version juggling:
thread 'main' (27164) panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/openssl-sys-0.9.109/build/main.rs:492:5:
This crate is only compatible with OpenSSL (version 1.0.1 through 1.1.1, or 3), or LibreSSL 2.5
through 4.1.x, but a different version of OpenSSL was found. > The build is now aborting
due to this version mismatch.
Set default versions for ripunzip and openssl in the workflow.
took me some time, but I understood the problem was the pull request trigger ignoring the input defaults, so both ripunzip and openssl were being built from |
esbena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh.
(There should be a codeql query for that, or some ergonomic TWF workaround.)
In particular the
macos-13image is undergoing brownout, but we can update all images here while we're at it.