Skip to content

Conversation

@redsun82
Copy link
Contributor

@redsun82 redsun82 commented Nov 10, 2025

In particular the macos-13 image is undergoing brownout, but we can update all images here while we're at it.

@redsun82 redsun82 requested a review from a team as a code owner November 10, 2025 08:51
Copilot AI review requested due to automatic review settings November 10, 2025 08:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions workflow to use the newer macOS 15 runner for building ripunzip binaries.

  • Updates the macOS runner from macos-13 to macos-15 in the build matrix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@redsun82 redsun82 changed the title CI: remove deprecated macos-13 image CI: update images in build-ripunzip.yml Nov 10, 2025
Copy link
Contributor

@esbena esbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it needs some version juggling:

thread 'main' (27164) panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/openssl-sys-0.9.109/build/main.rs:492:5:

This crate is only compatible with OpenSSL (version 1.0.1 through 1.1.1, or 3), or LibreSSL 2.5
through 4.1.x, but a different version of OpenSSL was found. > The build is now aborting
due to this version mismatch.

Set default versions for ripunzip and openssl in the workflow.
@redsun82
Copy link
Contributor Author

LGTM. But it needs some version juggling:

thread 'main' (27164) panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/openssl-sys-0.9.109/build/main.rs:492:5:
This crate is only compatible with OpenSSL (version 1.0.1 through 1.1.1, or 3), or LibreSSL 2.5
through 4.1.x, but a different version of OpenSSL was found. > The build is now aborting
due to this version mismatch.

took me some time, but I understood the problem was the pull request trigger ignoring the input defaults, so both ripunzip and openssl were being built from main (and the latter is unsupported by the opensll-sys crate)

Copy link
Contributor

@esbena esbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh.
(There should be a codeql query for that, or some ergonomic TWF workaround.)

@redsun82 redsun82 merged commit 3de598e into main Nov 10, 2025
10 checks passed
@redsun82 redsun82 deleted the redsun82/remove-macos-13 branch November 10, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants