Skip to content

Conversation

@redsun82
Copy link
Contributor

No description provided.

@redsun82 redsun82 requested a review from a team as a code owner November 11, 2025 10:53
Copilot AI review requested due to automatic review settings November 11, 2025 10:53
@redsun82 redsun82 requested a review from a team as a code owner November 11, 2025 10:53
@github-actions github-actions bot added the JS label Nov 11, 2025
Copilot finished reviewing on behalf of redsun82 November 11, 2025 10:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Boolean comparisons throughout the JavaScript extractor codebase to use .equals() instead of == operator, addressing errors from an upcoming rules_java update that enforces proper object comparison methods.

  • Replaces identity comparisons (==/!=) with .equals() calls for Boolean object comparisons
  • Adds @SuppressWarnings("ReturnValueIgnored") annotations to methods that intentionally ignore return values
  • Affects AST node constructors and parser logic across multiple files

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 17 comments.

Show a summary per file
File Description
Quantifier.java Updates greedy flag comparison in regexp quantifier constructor
CharacterClass.java Updates inverted flag comparison in regexp character class constructor
UnaryTypeConstructor.java Updates prefix flag comparison in JSDoc type constructor
FunctionType.java Updates _new flag comparison in JSDoc function type constructor
YieldExpression.java Updates delegating flag comparison in yield expression constructor
UpdateExpression.java Updates prefix flag comparison in update expression constructor
UnaryExpression.java Updates prefix flag comparison in unary expression constructor
TemplateElement.java Updates tail flag comparison in template element constructor
Property.java Updates computed and method flag comparisons in property constructor
MemberExpression.java Updates computed, optional, and onOptionalChain flag comparisons
Literal.java Updates value comparison in isFalsy() method
InvokeExpression.java Updates optional and onOptionalChain flag comparisons
ForInStatement.java Updates each flag comparison in for-in statement constructor
ComprehensionExpression.java Updates generator flag comparison in comprehension expression
ComprehensionBlock.java Updates of flag comparison in comprehension block constructor
AFunctionExpression.java Updates generator and async flag comparisons when creating function info
FlowParser.java Adds suppression annotation for intentionally ignored return value
Parser.java Updates oldStrict comparison and adds suppression annotation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@redsun82 redsun82 merged commit 68a0358 into main Nov 14, 2025
9 checks passed
@redsun82 redsun82 deleted the redsun82/update-rules_java branch November 14, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants