Rust: Cache inferCertainType
#20845
Merged
Rust: Cache inferCertainType
#20845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, this shouldn't be needed, as we already cache `inferType`. However, since we have consistency checks that directly call `inferCertainType`, we need to cache it as well to avoid recomputation.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds caching to the inferCertainType predicate in the Rust type inference library to avoid recomputation during nightly DCA (Dataflow Coverage Analysis). The change complements the existing caching of inferType, which is needed because consistency checks directly call inferCertainType.
- Moved
CachedStagesimport to top-level module scope - Added
cachedannotation toinferCertainTypepredicate - Added stage reference constraint to control evaluation timing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
geoffw0
approved these changes
Nov 18, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
nightly DCA (Dataflow Coverage Analysis)
Good guess, Copilot. Wrong, but good guess.
LGTM. I suspect the improvement won't affect most customers (since they have little reason to run the consistency checks), but its a nice improvement to have nonetheless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, this shouldn't be needed, as we already cache
inferType. However, since we have consistency checks that directly callinferCertainType, we need to cache it as well to avoid recomputation in nightly DCA.