Actions: note imprecision of MissingActionsPermissions.ql #20970
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note to the query's qhelp to note its imprecision, but also encourage usage of a permissions block regardless as a belt-and-braces measure.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a note to the MissingActionsPermissions.md documentation to clarify the query's limitations and encourage best practices for GitHub Actions permissions.
- Adds a disclaimer that the query cannot check organization or repository-level token settings
- Recommends explicit permissions definitions as a best practice even when defaults are secure
- Provides rationale for explicit permissions: documentation of needs and protection against configuration changes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
owen-mc
approved these changes
Dec 5, 2025
smowton
deleted the
smowton/admin/document-missing-actions-permissions-shortcomings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a note to the query's qhelp to note its imprecision, but also encourage usage of a permissions block regardless as a belt-and-braces measure.