Set current database automatically #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shati Patel <shati-patel@github.com>
elenatanasoiu
force-pushed
the
elena/set-current-database
branch
from
ad73b38 to
87133a9
Compare
3 tasks
shati-patel
approved these changes
Jan 31, 2023
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Small wording suggestion, otherwise LGTM ✏️
elenatanasoiu
force-pushed
the
elena/set-current-database
branch
from
7a08e8f to
8b29113
Compare
Contributor
Author
|
Going to wait on merging this until the next extension release so that we have the command available. |
aeisenberg
reviewed
Feb 2, 2023
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on github/vscode-codeql#2027 getting merged first.
At the moment we're asking the user to manually right click on
the database folder ('codeql-tutorial-database') and set it as
the current database.
We can take this one step further by defining a command that gets
triggered when we arrive at the step for setting up the database.
The command ("codeQL.setDefaultTourDatabase") will build the URI
pointing to our preloaded database and set it as the current one.
We initially considered whether we can re-use the setCurrentDatabase
command and pass the URI of the database from the codespace itself,
but the URI would be hardcoded as:
as we can only pass the codeTour extension a command and string
parameters.
This would have been brittle as the filepath for a codespace might
change in the future.
Instead we can define a custom tour command ("setDefaultTourDatabase")
to look at the current workspace folder and build the path to the
database in the CodeQL extension.