cleaned up unnecessary requirements, updated django #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshaber
approved these changes
Jan 9, 2023
Contributor
joshaber
left a comment
joshaber
left a comment
There was a problem hiding this comment.
Awesome, thanks for cleaning this up! ⚡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ton of requirements have been added (possibly from OP's environment) which are unncessary, and add to storage costs for those using the templates - possibly even scaring them away from using them. Some of them such as tensorflow, pytorch are quite bulky and are definitely not needed for a simple django codespace.
As part of this PR:
Edit: Follow up PR based off-of this branch to reduce host cpu requirements for this template: #14