Normalize table styles across report views#105
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Refactors four report tables (Products, Models, Cost Centers, Organizations) to consume the shared th/thNum/td/tdNum Tailwind class constants from src/components/ui/tableStyles.ts instead of repeating long inline class strings, and wraps two of the tables in an overflow-x-auto container for consistency.
Changes:
- Replace duplicated header/cell Tailwind class strings with shared constants in
ProductUsageTable,ModelsView,CostCentersView, andOrganizationsView. - Wrap the Cost Centers and Organizations detail tables in an
overflow-x-autodiv. - Drop the
[&>tr:last-child>td]:border-b-0tbody selector from the affected tables.
Show a summary per file
| File | Description |
|---|---|
| src/views/OrganizationsView.tsx | Switches detail table to shared classes; adds horizontal scroll wrapper; removes last-row border-suppression selector. |
| src/views/ModelsView.tsx | Switches top-models table to shared classes; removes last-row border-suppression selector. |
| src/views/CostCentersView.tsx | Switches detail table to shared classes; adds horizontal scroll wrapper; removes last-row border-suppression selector. |
| src/components/ProductUsageTable.tsx | Replaces repeated header/cell class strings with shared constants for product and model rows. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Products, Models, Cost Centers, and Organizations tables had drifted from the shared report table standard through duplicated Tailwind class strings. This PR normalizes those views around the shared table styling constants while preserving the existing layout, scrolling behavior, interactions, and copy.
Changes
refactor: normalize table stylesTesting
npm run buildnpm run lintnpm testChecklist
npm run lint)