Skip to content

Clarify model AIC chart units#124

Merged
asizikov merged 1 commit into
mainfrom
asizikov/model-aic-chart
May 22, 2026
Merged

Clarify model AIC chart units#124
asizikov merged 1 commit into
mainfrom
asizikov/model-aic-chart

Conversation

@asizikov
Copy link
Copy Markdown
Member

Summary

Clarifies the Models view so the average chart is presented as AICs per PRU rather than AICs per request. This avoids implying that PRU-normalized report quantities are directly comparable to actual request counts across models.

Changes

Commit Change
fix: clarify model AIC chart units Relabeled the model average and volume charts to use PRU terminology and added a note that PRU quantities include billing-period model multipliers.

Testing

  • npm run lint -- --quiet
  • npm run test
  • npm run build

Checklist

  • Specs lint passes (npm run lint)
  • Tests updated if applicable
  • Documentation updated if applicable

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 22, 2026 07:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Clarifies the Models view’s charts by relabeling request-derived metrics as PRU-normalized (Premium Request Units) and adding an explanatory note so readers don’t conflate PRU quantities with actual request counts when comparing models.

Changes:

  • Relabeled the daily average AIC chart from “per request” to “per PRU”.
  • Renamed the daily volume chart from “Requests” to “PRUs” and adjusted series labeling accordingly.
  • Added a note explaining that PRU quantities include model multipliers and aren’t directly comparable to raw request counts across models.
Show a summary per file
File Description
src/views/ModelsView.tsx Updates chart titles/labels to PRU terminology and adds a clarifying note about PRU multipliers.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

Comment thread src/views/ModelsView.tsx
Comment thread src/views/ModelsView.tsx
@asizikov asizikov merged commit 90cd1e9 into main May 22, 2026
10 checks passed
@asizikov asizikov deleted the asizikov/model-aic-chart branch May 22, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants