-
Notifications
You must be signed in to change notification settings - Fork 2
[FEAT]: Make it so the run-smoke-test workflow has added coverage to run the smoke test on Java 25 #45
Description
Describe the need
Consider .github/workflows/run-smoke-test.yml.
This workflow imperatively causes the smoke test specified in .github/workflows/run-smoke-test.yml to be run, with several, ✅✅extremely important✅✅ overrides so that the test is appropriate in the context of a CI/CD test.
The assignee of this issue must make an additive change to .github/workflows/run-smoke-test.yml so that the JDK 25 Virtual Thread specific behavior is also smoke tested.
Here are some invariant high level guides to the assginee.
-
Existing job
smoke-testmust be renamedsmoke-test-jdk-17. -
Create a net-new job,
smoke-test-jdk-25.-
This job is largely a copy/paste of
smoke-test-jdk-17but with the following changes.-
Run with the Microsoft JDK 25. ❌❌NOT temurin❌❌.
-
Extremely important ✅✅additional✅✅ Critical override statements.
-
Tell the agent to heed the "comment/uncomment" instructions in the Quick Start section of the top level
READMEthat have the literal prefix "// JDK 25+:"- These changes will make the resultant
CopilotSDKclass exercise the Java 25 Virtual Thread code path.
- These changes will make the resultant
-
Make it so these comment/uncomment changes happen before building the jar whose
mainisCopilotSDK.
-
-
-
The topic branch name for this work must include the issue number for this issue.
SDK Version
0.2.1
Relevant log output
Code of Conduct
- I agree to follow this project's Code of Conduct