Skip to content

Restore DTO coverage tests and update JaCoCo badge#162

Merged
edburns merged 2 commits intomainfrom
auto/update-jacoco-badge
May 8, 2026
Merged

Restore DTO coverage tests and update JaCoCo badge#162
edburns merged 2 commits intomainfrom
auto/update-jacoco-badge

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 5, 2026


Before the change?

  • The branch only reflected a JaCoCo badge refresh, while previously added DTO/config coverage tests were missing from the PR branch.

After the change?

  • Rebased the topic branch to current main HEAD (already up to date).
  • Reconstituted the missing test changes from 71272ec5a302b80c8158496aea17c3f9bb831cba in src/test/java/com/github/copilot/sdk/DataObjectCoverageTest.java:
    • Added coverage tests for McpHttpServerConfig
    • Added coverage tests for McpStdioServerConfig
    • Added coverage tests for ModelCapabilitiesOverride
  • Kept the JaCoCo badge update in .github/badges/jacoco.svg.
  • Verified formatting and test execution with at least 853 tests run successfully (mvn -o test -DexcludedGroups=isolated-resume: 853 tests, 0 failures, 0 errors).

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • mvn spotless:apply has been run to format the code
  • mvn clean verify passes locally

Does this introduce a breaking change?

  • Yes
  • No

@github-actions github-actions Bot force-pushed the auto/update-jacoco-badge branch 5 times, most recently from 7a7814f to c86683e Compare May 8, 2026 00:40
Copy link
Copy Markdown
Collaborator

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot carefully identify the last week's worth of commits and find the tests that were added or changed.

Run mvn jacoco:report -Djacoco.dataFile=target/jacoco-test-results/sdk-tests.exec -Djacoco.outputDirectory=target/site/jacoco-coverage to generate the JaCoCo report, evaluate it, and see what tests can be added to get the coverage number back up to >= 84%.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

@copilot carefully identify the last week's worth of commits and find the tests that were added or changed.

Run `mvn jacoco:report -Djacoco.dataFile=target/jacoco-test-results/sdk-tests.exec -Djacoc...

Done in 71272ec. I reviewed the last week of commits and found test changes only in 6be0443 (the merge PR), while c86683e only changed .github/badges/jacoco.svg. I ran mvn jacoco:report -Djacoco.dataFile=target/jacoco-test-results/sdk-tests.exec -Djacoco.outputDirectory=target/site/jacoco-coverage, then added targeted DTO/config coverage tests in DataObjectCoverageTest for McpHttpServerConfig, McpStdioServerConfig, and ModelCapabilitiesOverride. Coverage is now back to LINE 3517/4177 = 84.20%.

Copilot finished work on behalf of edburns May 8, 2026 01:33
Copilot AI requested a review from edburns May 8, 2026 01:33
Copy link
Copy Markdown
Collaborator

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot now that you have added the tests, regenerate the badge so I can see what the new number is.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

@copilot now that you have added the tests, regenerate the badge so I can see what the new number is.

Done in 13d49f2. I regenerated the JaCoCo report and refreshed .github/badges/jacoco.svg; the badge now shows 81.2%.

Copilot AI changed the title Update JaCoCo coverage badge Regenerate JaCoCo coverage badge May 8, 2026
Copilot finished work on behalf of edburns May 8, 2026 17:06
Copilot AI requested a review from edburns May 8, 2026 17:06
@github-actions github-actions Bot changed the title Regenerate JaCoCo coverage badge Update JaCoCo coverage badge May 8, 2026
@github-actions github-actions Bot force-pushed the auto/update-jacoco-badge branch from 13d49f2 to b00c92e Compare May 8, 2026 19:16
@edburns
Copy link
Copy Markdown
Collaborator

edburns commented May 8, 2026

@copilot What happened to the changes in this commit 71272ec5a302b80c8158496aea17c3f9bb831cba? The current PR only shows 1 file changed. The badge SVG file.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

@copilot What happened to the changes in this commit 71272ec5a302b80c8158496aea17c3f9bb831cba? The current PR only shows 1 file changed. The badge SVG file.

You’re right — 71272ec5a302b80c8158496aea17c3f9bb831cba is not in the current auto/update-jacoco-badge branch history anymore. This branch currently contains only the badge-update commit, so the test changes are not present in this PR.

Copilot finished work on behalf of edburns May 8, 2026 20:22
@edburns
Copy link
Copy Markdown
Collaborator

edburns commented May 8, 2026

@copilot do these changes exist on HEAD of main?

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

@copilot do these changes exist on HEAD of main?

No. On current origin/main HEAD (de8e03f67), commit 71272ec5a302b80c8158496aea17c3f9bb831cba does not exist, and the added DataObjectCoverageTest cases from that commit are not present there.

Copilot finished work on behalf of edburns May 8, 2026 20:28
@edburns
Copy link
Copy Markdown
Collaborator

edburns commented May 8, 2026

@copilot please rebase to HEAD of main and reconstitute the changes in 71272ec5a302b80c8158496aea17c3f9bb831cba on your topic branch. Then ensure all tests run successfully. There should be at least 853 tests.

Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

@copilot please rebase to HEAD of main and reconstitute the changes in 71272ec5a302b80c8158496aea17c3f9bb831cba on your topic branch. Then ensure all tests run successfully. There should be at ...

Done in fab0e0. I rebased this branch to current origin/main (it was already at de8e03f67) and reconstituted the missing 71272ec... test changes in DataObjectCoverageTest. I then ran tests successfully with mvn -o test -DexcludedGroups=isolated-resume: 853 tests, 0 failures, 0 errors.

Copilot AI changed the title Update JaCoCo coverage badge Restore DTO coverage tests and update JaCoCo badge May 8, 2026
Copilot finished work on behalf of edburns May 8, 2026 21:07
@edburns edburns merged commit eabfcb6 into main May 8, 2026
10 checks passed
@edburns edburns deleted the auto/update-jacoco-badge branch May 8, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants