Conversation
|
Merge this when https://www.githubstatus.com/ returns to all clear. |
There was a problem hiding this comment.
Pull request overview
Re-enables repository pre-commit hook enforcement in the Copilot coding agent environment and documents how to handle hook failures.
Changes:
- Configure the Copilot setup workflow to enable repository hooks via
core.hooksPath. - Add Copilot-specific documentation describing the pre-commit hook behavior and remediation steps.
- Add workflow logging to show the configured hooks path during setup verification.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/copilot-setup-steps.yml |
Enables .githooks via git config core.hooksPath during Copilot agent setup and prints the configured hooks path. |
.github/copilot-instructions.md |
Adds guidance about pre-commit hook behavior in the Copilot coding agent environment and how to fix Spotless failures. |
| ## Pre-commit Hooks and Formatting (Coding Agent) | ||
|
|
||
| The repository has a pre-commit hook (`.githooks/pre-commit`) that is **automatically enabled** in the Copilot coding agent environment via `copilot-setup-steps.yml`. The hook runs `mvn spotless:check` on any commit that includes changes under `src/`. | ||
|
|
There was a problem hiding this comment.
This new section says the pre-commit hook is “automatically enabled” via copilot-setup-steps.yml, but earlier in the same document (and in CONTRIBUTING/README) the hook is described as something developers must manually enable with git config core.hooksPath .githooks. Please clarify the scope (e.g., auto-enabled only in the Copilot coding agent environment; local development still requires manual enablement) to avoid conflicting guidance, and consider linking explicitly to .github/workflows/copilot-setup-steps.yml for precision.
I have determined that a possible cause of the problems is a series of 500 errors on GitHub. Given that we reverted some commits in this session as a means to determine the cause of the problem, I would now like to un-revert those reversions and push those changes to upstream/edburns/re-enable-pre-commit-hooks.