Bump the java-codegen-deps group in /java/scripts/codegen with 2 updates#1364
Conversation
Bumps the java-codegen-deps group in /java/scripts/codegen with 2 updates: [@github/copilot](https://github.com/github/copilot-cli) and [tsx](https://github.com/privatenumber/tsx). Updates `@github/copilot` from 1.0.49-3 to 1.0.51 - [Release notes](https://github.com/github/copilot-cli/releases) - [Changelog](https://github.com/github/copilot-cli/blob/main/changelog.md) - [Commits](https://github.com/github/copilot-cli/commits/v1.0.51) Updates `tsx` from 4.21.0 to 4.22.3 - [Release notes](https://github.com/privatenumber/tsx/releases) - [Changelog](https://github.com/privatenumber/tsx/blob/master/release.config.cjs) - [Commits](privatenumber/tsx@v4.21.0...v4.22.3) --- updated-dependencies: - dependency-name: "@github/copilot" dependency-version: 1.0.51 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: java-codegen-deps - dependency-name: tsx dependency-version: 4.22.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: java-codegen-deps ... Signed-off-by: dependabot[bot] <support@github.com>
Auto-committed by java-codegen-check workflow.
The new @github/copilot schemas introduced cross-schema $ref references
in api.schema.json pointing to session-events.schema.json definitions:
- session-events.schema.json#/definitions/SessionEvent
- session-events.schema.json#/definitions/PermissionPromptRequest
The code generator only handled local #/definitions/ refs, causing invalid
Java type names to be emitted (the raw $ref string), which produced
compilation errors:
PendingPermissionRequest.java: illegal character '#'
SessionEventLogReadResult.java: '<identifier> expected', etc.
Fix in java/scripts/codegen/java.ts:
- Track generated session-events type names in generatedSessionEventsTypes
- Store session-events definitions in sessionEventsDefinitions
- In schemaTypeToJava, detect cross-schema refs and resolve them:
- If the type is already generated in the session-events package
(e.g. SessionEvent), emit it with the correct import
- Otherwise resolve inline using the external definitions
(anyOf unions like PermissionPromptRequest fall back to Object)
Regenerated affected files:
PendingPermissionRequest.java: request field now typed as Object
SessionEventLogReadResult.java: events field now typed as List<SessionEvent>
Automated fix applied by java-codegen-fix workflow.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Commit pushed:
|
|
Hi @stephentoub, I'm closing this PR for now. The same changes were brought over (also agentically) from copilot-sdk-java#224 as #1389, using the existing agentic sync process from the standalone Java repo. I'd like to defer to whatever direction you and the team settle on in ghcp-sp-109 for the long-term maintenance policy. Once that's decided, we'll shut down Java SDK's standalone repo sync process accordingly — currently it just runs weekly on Fridays, and I'm happy to turn it off or adapt it to whatever workflow makes the most sense for the monorepo. Please let me know if you'd prefer a different approach in the meantime. |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Superseded by #1389 .
Bumps the java-codegen-deps group in /java/scripts/codegen with 2 updates: @github/copilot and tsx.
Updates
@github/copilotfrom 1.0.49-3 to 1.0.51Release notes
Sourced from @github/copilot's releases.
... (truncated)
Changelog
Sourced from @github/copilot's changelog.
... (truncated)
Commits
Updates
tsxfrom 4.21.0 to 4.22.3Release notes
Sourced from tsx's releases.
... (truncated)
Commits
dce02fcfix: decode typed loader source68f72f3fix: preserve entrypoint with TypeScript preload hooks69455cftest: cover package exports for ambiguous ESM reexports35b700bfix: preserve CJS JSON require in ESM hooksef807dbchore: update testing dependencies3917090test: document compatibility test taxonomyde8113frefactor: centralize Node capability factsc1f62dbtest: consolidate tsconfig path edge coverage4e08174test: consolidate loader hook coverage674bb30test: consolidate tsImport commonjs mts coverageMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for tsx since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions