Remove test/scenarios and scenario-builds CI#1448
Merged
Merged
Conversation
The scenario compile checks are redundant with the per-language SDK test workflows (dotnet-sdk-tests, go-sdk-tests, java-sdk-tests, etc.) which already build and test the SDK on every PR. The scenarios remain in the repo as documentation/examples and can still be verified on-demand. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
stephentoub
approved these changes
May 27, 2026
edburns
added a commit
that referenced
this pull request
May 27, 2026
The scenario-builds infrastructure was removed from main in PR #1448 because per-language SDK test workflows (java-sdk-tests, etc.) already cover build/test verification. Remove the orphaned Java scenario files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
edburns
added a commit
that referenced
this pull request
May 27, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edburns
added a commit
to edburns/copilot-sdk
that referenced
this pull request
May 27, 2026
* Preserve 80-java-monorepo-add-01-remove-before-merge directory * Complete Phase 03 * Start iterating Phase 05 * WIP: Phase 05 * WIP Phase 05: github#1423 * Add Java scenarios: Phase 1 (size S, #1-github#16) Add 16 Java scenario implementations covering: - modes: default, minimal - prompts: system-message, reasoning-effort - sessions: streaming, infinite-sessions - tools: no-tools, tool-filtering - transport: stdio, tcp - callbacks: user-input - auth: byok-openai, byok-azure, byok-anthropic - bundling: fully-bundled, app-direct-server All scenarios compile successfully with mvn compile. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add Java scenarios: Phase 2 (size M, github#17-github#26) Add 10 Java scenario implementations covering: - callbacks: hooks (pre/post tool use, session start/end), permissions - prompts: attachments - sessions: concurrent-sessions, session-resume - tools: custom-agents, tool-overrides, mcp-servers, skills - auth: gh-app (OAuth device flow) All scenarios compile successfully with mvn compile. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update Phase 05 * Ready to have agent do docs-validation.yml * Use correct day * Phase 05 Update docs-validation.yml to include Java code snippets. * Prepare for phase 05 review * Prepare for phase 05 review: remove prompts. * Fix Java scenarios: update imports after package rename (com.github.copilot.sdk -> com.github.copilot) * Abide by @patniko github#1448 and remove scenario-builds.yml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address review feedback: idempotent Java validation, path filter, README links - Copy .java files instead of moving them so validation is idempotent - Add java/pom.xml to docs-validation.yml path trigger - Update README Java install links to ./java/README.md anchors Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Change Java distribution from 'temurin' to 'microsoft' --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
test/scenarios/directory (414 files) and associated CI workflow + justfile tasks.Rationale
The scenario builds only verify that example programs compile against the SDK. Investigation of the last 50 CI runs showed that every failure caught by
scenario-builds.ymlwas already caught by the per-language SDK test workflows (dotnet-sdk-tests,go-sdk-tests,java-sdk-tests, etc.), making the scenarios redundant as CI checks.The example code will be brought back as documentation instead.
Changes
test/scenarios/— 414 example files across 8 categories and 5 languages.github/workflows/scenario-builds.yml— the CI workflow that built them on every PRscenario-build,scenario-verify, andscenario-build-langtasks fromjustfile.gitignoreentries for Rust scenario build artifacts