Use jsoncreator for AgentMode ctor, per review comments.#1465
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Java AgentMode RPC type to support Jackson deserialization via @JsonCreator, aligning it with the generated enum patterns used elsewhere in the SDK.
Changes:
- Added
@JsonCreator-annotatedAgentMode.fromValue(String)to deserialize JSON string values into the enum. - Updated the
@sincetag onAgentMode(now1.1.0).
Show a summary per file
| File | Description |
|---|---|
| java/src/main/java/com/github/copilot/rpc/AgentMode.java | Adds Jackson @JsonCreator deserialization and updates Javadoc metadata for the enum. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Revert @SInCE tag from 1.1.0 to 1.0.0 for consistency with SendMessageRequest which already references AgentMode - Fix error message format to 'Unknown AgentMode value: ...' matching the convention used by generated enum fromValue methods - Add AgentModeTest covering serialization, deserialization, round-trip, null handling, and unknown-value error behavior Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edburns
commented
May 27, 2026
Collaborator
Author
edburns
left a comment
edburns
left a comment
There was a problem hiding this comment.
Human review of copilot authored changes. LGTM.
edburns
added a commit
to github/copilot-sdk-java
that referenced
this pull request
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.