Skip to content

Re-invalidate build.rs when extracted CLI cache is removed #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveSandersonMS merged 2 commits into from
May 28, 2026
Merged

Re-invalidate build.rs when extracted CLI cache is removed #1480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcaee4d
Re-invalidate build.rs when extracted CLI cache is removed
tclem May 28, 2026
f68a6d1
Add comment clarifying post-condition check on extracted binary
tclem May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion rust/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ fn main() {
let install_dir = extracted_install_dir(&version);
let final_path = install_dir.join(platform.binary_name);

// Invalidate build.rs whenever the cached binary disappears (cache GC,
// manual rm, OS reset, switching extract dir). Without this, cargo
// replays the saved `has_extracted_cli` cfg from its build-script
// output cache even when the file is gone, and runtime resolution
// fails with BinaryNotFound.
println!("cargo:rerun-if-changed={}", final_path.display());

if !final_path.is_file() {
let archive = cached_download(
&format!("{base_url}/{}", platform.asset_name),
Expand All @@ -117,7 +124,11 @@ fn main() {
extract_to_cache(&archive, &install_dir, platform);
}

println!("cargo:rustc-cfg=has_extracted_cli");
// Re-check after potential download+extract above; not an `else`
// because we need to verify the extraction actually produced the file.
if final_path.is_file() {
println!("cargo:rustc-cfg=has_extracted_cli");
}
}
}

Expand Down
Loading