Apply review comments from standalone backport.#1486
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Applies review feedback from the standalone Java backport PR by tightening documentation around EMPTY-mode defaulting, aligning source headers, fixing README formatting, and improving CI artifact collection for Java tests.
Changes:
- Update Javadoc for
mcpOAuthTokenStorageto describe EMPTY-mode-only defaulting behavior. - Add missing license header to
LargeToolOutputConfig. - Fix Gradle snippet formatting in
java/README.mdand upload additional test reports in Java CI.
Show a summary per file
| File | Description |
|---|---|
| java/src/main/java/com/github/copilot/rpc/SessionConfig.java | Updates Javadoc explaining when MCP OAuth token storage defaults are applied. |
| java/src/main/java/com/github/copilot/rpc/ResumeSessionConfig.java | Mirrors the same Javadoc clarification for resume-session configs. |
| java/src/main/java/com/github/copilot/rpc/LargeToolOutputConfig.java | Adds standard Microsoft/MIT license header to match other RPC types. |
| java/README.md | Fixes a broken/malformed Gradle code block. |
| .github/workflows/java-sdk-tests.yml | Attempts to include failsafe integration-test reports in failure artifacts. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 3
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Fix formatting of Javadoc comment for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review comments from github/copilot-sdk-java#237 .