Skip to content

Update to use correct package name for generated#1499

Merged
edburns merged 1 commit into
mainfrom
edburns/resolve-jacoco-badge-content-problems
May 29, 2026
Merged

Update to use correct package name for generated#1499
edburns merged 1 commit into
mainfrom
edburns/resolve-jacoco-badge-content-problems

Conversation

@edburns
Copy link
Copy Markdown
Collaborator

@edburns edburns commented May 29, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 29, 2026 18:38
@edburns edburns requested a review from a team as a code owner May 29, 2026 18:38
@edburns edburns enabled auto-merge May 29, 2026 18:39
@edburns edburns disabled auto-merge May 29, 2026 18:39
@edburns edburns enabled auto-merge May 29, 2026 18:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Java JaCoCo badge-generation script to correctly classify generated Java sources based on their package prefix (used by CI to generate coverage badges from jacoco.csv).

Changes:

  • Update GENERATED_PREFIX to com.github.copilot.generated (matching the current generated Java package).
  • Remove “overall” coverage calculation/output and stop generating the jacoco.svg badge (only handwritten + generated badges remain).
Show a summary per file
File Description
.github/scripts/generate-java-coverage-badge.sh Updates generated-package prefix used to split JaCoCo coverage; also changes which badges are emitted.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment on lines 90 to 94
mkdir -p "$BADGES_DIR"

read -r overall_missed overall_covered <<< "$(calc_totals overall)"
read -r handwritten_missed handwritten_covered <<< "$(calc_totals handwritten)"
read -r generated_missed generated_covered <<< "$(calc_totals generated)"

@edburns edburns disabled auto-merge May 29, 2026 18:43
@edburns edburns merged commit 9fd30cc into main May 29, 2026
15 checks passed
@edburns edburns deleted the edburns/resolve-jacoco-badge-content-problems branch May 29, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants