Java: Make it so slash command responses are accessible via RPC#1520
Merged
Conversation
Fix the Java codegen to produce proper return types for RPC methods whose result schema uses $ref to named definitions. Previously these all fell through to CompletableFuture<Void>. Changes to java/scripts/codegen/java.ts: - Add findDiscriminator() to detect anyOf unions with a shared const property (ported from the C# codegen pattern) - Add generatePolymorphicResultClass() and variant class generation using Jackson @JsonTypeInfo/@JsonSubTypes annotations - Update wrapperResultClassName() to recognize $ref to enums, anyOf discriminated unions, and named empty objects - Update generateRpcTypes() to generate appropriate classes for each result schema pattern (enum, anyOf, empty object) - Update generatePendingStandaloneTypes() to handle anyOf schemas Affected API methods: - session.commands.invoke → CompletableFuture<SlashCommandInvocationResult> (polymorphic: text, agent-prompt, completed, select-subcommand) - session.mode.get → CompletableFuture<SessionMode> (string enum) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
On branch edburns/java-slash-command-tests modified: java/src/test/java/com/github/copilot/SlashCommandsIT.java
On branch edburns/java-slash-command-tests modified: java/src/test/java/com/github/copilot/TestUtil.java modified: java/src/test/java/com/github/copilot/generated/GeneratedTypesJacksonRoundTripTest.java no changes added to commit (use "git add" and/or "git commit -a")
On branch edburns/java-slash-command-tests modified: java/src/test/java/com/github/copilot/TestUtil.java modified: java/src/test/java/com/github/copilot/generated/GeneratedTypesJacksonRoundTripTest.java no changes added to commit (use "git add" and/or "git commit -a")
On branch edburns/java-slash-command-tests Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: java/pom.xml no changes added to commit (use "git add" and/or "git commit -a")
On branch edburns/java-slash-command-tests modified: java/src/test/java/com/github/copilot/SlashCommandsIT.java
On branch edburns/java-slash-command-tests modified: java/src/test/java/com/github/copilot/SlashCommandsIT.java no changes added to commit (use "git add" and/or "git commit -a")
edburns
force-pushed
the
edburns/java-slash-command-tests
branch
from
11aa504 to
9c39e91
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java
Last minute gap analysis promted by this question by Zidong Li:
prompted me to investigate this. Turns out the ability to invoke slash commands was there, but the ability to obtain the responses was not.