Skip to content

Java: adr recording decision to keep everything in one module#1588

Merged
edburns merged 3 commits into
mainfrom
edburns/ghcp-1573-java-adr-codegen-module
Jun 5, 2026
Merged

Java: adr recording decision to keep everything in one module#1588
edburns merged 3 commits into
mainfrom
edburns/ghcp-1573-java-adr-codegen-module

Conversation

@edburns
Copy link
Copy Markdown
Collaborator

@edburns edburns commented Jun 5, 2026

No description provided.

@edburns edburns requested a review from a team as a code owner June 5, 2026 19:51
Copilot AI review requested due to automatic review settings June 5, 2026 19:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Java Architecture Decision Record (ADR) documenting the decision to keep generated Java sources in the existing single copilot-sdk-java Maven module, noting that a sub-module split wouldn’t materially reduce the public API surface and would complicate stability/deprecation metadata propagation.

Changes:

  • Introduces ADR-003 capturing the considered module-splitting options and rationale.
  • Documents the decision to keep generated code and handwritten code in one module for simpler build/annotation constraints.
  • Links related tracking items for follow-up work on stability/deprecation metadata.
Show a summary per file
File Description
java/docs/adr/adr-003-sub-module-for-generated-code.md New ADR documenting analysis and decision to keep generated code in the main Java module.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

SDK Consistency Review ✅

This PR adds a single Architecture Decision Record (java/docs/adr/adr-003-sub-module-for-generated-code.md) and makes no changes to SDK code or public APIs.

No cross-SDK consistency issues. This is a Java-specific build-architecture decision (Maven module structure for generated code) with no equivalent concept in the other SDK implementations (Node.js, Python, Go, .NET, Rust). No action required in other language SDKs.

Generated by SDK Consistency Review Agent for issue #1588 · sonnet46 408.1K ·

@edburns edburns force-pushed the edburns/ghcp-1573-java-adr-codegen-module branch from f9f38b0 to 3be53e2 Compare June 5, 2026 20:08
@edburns edburns merged commit 0a25600 into main Jun 5, 2026
11 checks passed
@edburns edburns deleted the edburns/ghcp-1573-java-adr-codegen-module branch June 5, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants