Fix snapshot filename collisions on case-insensitive filesystems #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All SDK test harnesses now generate lowercase snapshot filenames to avoid collisions when checking out on macOS/Windows (case-insensitive filesystems). - Node.js: Added .toLowerCase() to filename generation - Go: Added strings.ToLower() to filename generation - .NET: Simplified to single regex + ToLowerInvariant() - Python: Added .lower() to filename generation Also renamed existing snapshot files to lowercase and removed duplicates that only differed by case.
There was a problem hiding this comment.
Pull request overview
This PR fixes snapshot filename collisions that occur on case-insensitive filesystems (macOS/Windows) by ensuring all SDK test harnesses generate lowercase snapshot filenames.
Changes:
- Modified filename generation in all four SDK test harnesses (Node.js, Go, Python, .NET) to convert test names to lowercase
- Renamed existing snapshot files from mixed-case to lowercase (e.g., accept_MCP_* → accept_mcp_*)
- Removed duplicate snapshot files that only differed by case
Reviewed changes
Copilot reviewed 7 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| python/e2e/testharness/context.py | Added .lower() to sanitized test name generation |
| nodejs/test/e2e/harness/sdkTestContext.ts | Added .toLowerCase() to task name filename conversion |
| go/e2e/testharness/context.go | Added strings.ToLower() to sanitized name generation |
| dotnet/test/Harness/E2ETestContext.cs | Simplified regex logic and added .ToLowerInvariant() |
| test/snapshots/mcpservers/accept_mcp_server_config_on_create.yaml | New lowercase snapshot file |
| test/snapshots/mcpservers/accept_mcp_server_config_on_resume.yaml | New lowercase snapshot file |
| test/snapshots/mcpservers/accept_MCP_server_config_on_create.yaml | Removed mixed-case duplicate |
| test/snapshots/mcpservers/accept_MCP_server_config_on_resume.yaml | Removed mixed-case duplicate |
| test/snapshots/mcp-and-agents/should_accept_both_MCP_servers_and_custom_agents.yaml | Removed mixed-case duplicate (moved to combinedconfiguration) |
| test/snapshots/combinedconfiguration/accept_mcp_servers_and_custom_agents.yaml | New lowercase snapshot file |
| test/snapshots/session/should_create_a_session_with_replaced_systemmessage_config.yaml | New lowercase snapshot file |
| test/snapshots/session/should_create_a_session_with_excludedtools.yaml | New lowercase snapshot file |
| test/snapshots/session/should_create_a_session_with_availabletools.yaml | New lowercase snapshot file |
| test/snapshots/session/should_create_a_session_with_appended_systemmessage_config.yaml | New lowercase snapshot file |
| test/snapshots/permissions/should_receive_toolcallid_in_permission_requests.yaml | New lowercase snapshot file |
| test/snapshots/ask/should_invoke_onevent_callback_for_each_event.yaml | New lowercase snapshot file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SteveSandersonMS
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK test harnesses now generate lowercase snapshot filenames to avoid collisions when checking out on macOS/Windows (case-insensitive filesystems).
Also renamed existing snapshot files to lowercase and removed duplicates that only differed by case.