Re-enable npm publish step in workflow #7
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request re-enables the npm publish step in the publish workflow by uncommenting the npm publish command that was previously disabled with a TODO comment.
Changes:
- Re-enabled the npm publish step to allow publishing Node.js SDK packages to the npm registry
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Publish to npm | ||
| run: npm publish --tag ${{ github.event.inputs.dist-tag }} --access public --registry https://registry.npmjs.org |
There was a problem hiding this comment.
The npm publish step is missing authentication configuration. Unlike the .NET and Python publish steps which include explicit authentication mechanisms (NuGet/login for .NET and pypa/gh-action-pypi-publish for Python), this step doesn't configure any authentication. The npm publish command will fail without either: 1) an NPM_TOKEN or NODE_AUTH_TOKEN environment variable, or 2) proper OIDC configuration if npm 11.6.3 supports it natively. Consider adding authentication setup similar to the .NET publish job, or using actions/setup-node with registry-url and NODE_AUTH_TOKEN configuration.
No description provided.