fix: Cross-SDK Consistency Reviewer posts duplicate comments per commit#983
Conversation
- Add tracker-id: sdk-consistency-review to identify workflow's comments - Add hide-older-comments: true (with allowed-reasons: [outdated]) to add-comment safe-output so older comments are hidden before a new one is posted on each commit - Move roles: all under on: block (codemod roles-to-on-roles, v0.10.0) required to compile with current gh aw v0.65.5 - Recompile both sdk-consistency-review.lock.yml and issue-triage.lock.yml (same roles migration needed for the latter to compile too) Agent-Logs-Url: https://github.com/github/copilot-sdk/sessions/c025f75a-3f57-4fde-8282-0768b84d77cf Co-authored-by: SteveSandersonMS <1101362+SteveSandersonMS@users.noreply.github.com>
|
@copilot Explain why this PR makes big changes in .github/agents and .github/aw/schemas. |
gh aw fix --write applied extra codemods beyond roles-to-on-roles: - replaced old per-task agent files with a new dispatcher agent file - deleted the agentic-workflow.json schema file (delete-schema-file codemod) These changes are unrelated to the duplicate-comment fix. Restore all four affected files to their original state. Agent-Logs-Url: https://github.com/github/copilot-sdk/sessions/5d0ca850-de42-4b6d-b65e-dec287140b60 Co-authored-by: SteveSandersonMS <1101362+SteveSandersonMS@users.noreply.github.com>
Those changes were unintended side-effects of running
Neither of these is relevant to the duplicate-comment fix. Reverted in c10105b — the PR now only touches the four workflow files it should: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Cross-SDK Consistency Reviewer workflow to avoid accumulating duplicate review comments on repeated synchronize events, and modernizes the affected agentic workflows to match the current gh-aw toolchain expectations.
Changes:
- Add a
tracker-idand enable “hide older comments” behavior for the reviewer’sadd-commentsafe-output to keep only the latest workflow comment visible. - Apply the
roles: all→on.roles: allcompatibility change forgh-aw v0.10.0+in both workflows. - Recompile the corresponding
.lock.ymlfiles withgh aw compile(updating the generated workflow implementations togh-aw v0.65.5output).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/sdk-consistency-review.md | Adds tracker-id and attempts to configure safe-output behavior to hide older comments; moves roles under on:. |
| .github/workflows/sdk-consistency-review.lock.yml | Regenerated compiled workflow reflecting new frontmatter and updated compiler output. |
| .github/workflows/issue-triage.md | Moves roles under on: for compatibility; minor formatting normalization. |
| .github/workflows/issue-triage.lock.yml | Regenerated compiled workflow reflecting updated frontmatter and compiler output. |
| add-comment: | ||
| max: 1 | ||
| hide-older-comments: true | ||
| allowed-reasons: [outdated] |
There was a problem hiding this comment.
allowed-reasons: [outdated] is present in the workflow frontmatter, but it does not appear to be reflected anywhere in the compiled .lock.yml (no allowed / outdated references, and the generated safe-outputs config only includes hide_older_comments). This likely means the setting is being ignored by the compiler/version in use.
To avoid a false sense of safety (or a mismatch with the PR description), either update this to the correct supported key for gh-aw v0.65.5 (and recompile), or remove allowed-reasons and rely solely on hide-older-comments if that’s sufficient.
The Cross-SDK Consistency Reviewer runs on every
synchronizeevent, accumulating one full review comment per commit push — making PR review noisy and burying real feedback.Changes
sdk-consistency-review.mdtracker-id: sdk-consistency-review— required for the framework to identify which comments belong to this workflowhide-older-comments: true+allowed-reasons: [outdated]to theadd-commentsafe-output — minimizes all prior comments from this workflow before posting the new one, keeping only the latest review visiblesdk-consistency-review.md+issue-triage.md(compatibility)roles-to-on-rolescodemod (roles: all→on.roles: all), required since gh-aw v0.10.0; both workflows failed to compile with the current toolchain (v0.65.5).lock.ymlfiles viagh aw compileWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.65.5/usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.65.5 --jq .object.sha(http block)If you need me to access, download, or install something from one of these locations, you can either: