Avoid copy pod in the event loop #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is no need to copy the pod to the event object, the pod can be fetched from the informers cache.
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary deep copying of Pod objects in the controller's event handling. Instead of storing Pod copies in events, the controller now retrieves Pods directly from the informer's cache when processing events, reducing memory overhead and eliminating redundant data storage.
Key changes:
- Removed
Podfield fromPodEventstruct - Modified event processing to fetch Pods from the informer's cache using the event key
- Fixed a spelling error in an error message
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/controller/controller.go | Removed Pod field from PodEvent struct, eliminated DeepCopy() calls in event handlers, and updated processEvent to retrieve Pods from cache |
| cmd/deployment-tracker/main.go | Fixed typo in error message ("Organiation" → "Organization") |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.