-
Notifications
You must be signed in to change notification settings - Fork 66.6k
Poor instructions for getting starred_at property in stargazers endpoint #19563
Description
Code of Conduct
- I have read and agree to the GitHub Docs project's Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/rest/activity/starring
What part(s) of the article would you like to see updated?
Currently, it states this:
You can also find out when stars were created by passing the following custom media type via the Accept header:
But then it makes no mention of a value to use, and the page it links to doesn't provide the required header either.
The reason to use is mentioned above, in a previous section. The reality is more users are skimming through to the endpoint they need, so they may miss that and then not know what the docs are referring to.
In my opinion, it should say something more like:
You can also find out when stars were created by passing the custom media type for starring via the
Acceptheader.
(Anchored to the section above via fragment.)
You can also find out when stars were created by passing the following custom media type via the Accept header:
application/vnd.github.star+json
(Just specifies the header value they need afterwards.)
Or just underneath where the request data, the accept header should state under it:
Setting to
application/vnd.github.star+jsonis recommended.
Additional information
I wanted to PR this myself, but the only time I see this text occur is in lib/rest/static/*.json which is machine generated. 🤔
Wasn't sure where the source is and if that's accessible or maybe that's just internal GitHub stuff?