Skip to content

Conversation

@jstvz
Copy link
Contributor

@jstvz jstvz commented Oct 6, 2021

Why:

are not be propagated ➡️ are not propagated

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Oct 6, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 6, 2021
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 6, 2021
@ramyaparimi
Copy link
Contributor

@jstvz
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@skedwards88 skedwards88 added waiting for review Issue/PR is waiting for a writer's review and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 7, 2021
Copy link
Contributor

@ethanpalm ethanpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 Thanks for creating this PR, @jstvz! Your change looks great. I'll get this merged once the branch is up to date and all checks are passing.

Thanks for taking the time to contribute to the GitHub docs!

@ethanpalm ethanpalm enabled auto-merge October 8, 2021 17:49
@ethanpalm ethanpalm added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 8, 2021
@mattpollard mattpollard disabled auto-merge October 10, 2021 11:44
@mattpollard mattpollard reopened this Oct 10, 2021
@mattpollard mattpollard merged commit b361ca7 into github:main Oct 10, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants