Skip to content

Conversation

@lupinitylabs
Copy link
Contributor

Why:

Closes #10934

What's being changed:

This PR fixes a copy & paste error for the alt text for /assets/images/help/codespaces/codespaces-commit-pr.png, which seems to be copied from /assets/images/help/codespaces/codespaces-commit-pr-button.png.

It changes the previous alt text of Source control side bar with staging button highlighted to GitHub pull request side bar, which more accurately describes the content of the screenshot.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 8, 2021
@lupinitylabs
Copy link
Contributor Author

lupinitylabs commented Oct 8, 2021

What?

Excuse me, Ma'am or Sir?

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 8, 2021
@ramyaparimi
Copy link
Contributor

@lupinitylabs
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link

@Jassi10000-zz Jassi10000-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lupinitylabs Buddy I guess Alt text are completely in hand of the docs maintainer and obvio they must have written this considering some pts.

Thanks for your contributions but am afraid it may be not be considered or termed as invalid

You can look out for some other nice issues to contribute to

All the best!!!

@lupinitylabs
Copy link
Contributor Author

@Jassi10000 I just encountered this when working on something else and I don't know why someone would want the same alt text for two completely different images, considering the alt should help robots to index and screenreaders to describe what's going on in the picture.

In the end, it's just a pointer towards a potential issue. If you don't need it, no offense taken 😉

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@mchammer01 mchammer01 enabled auto-merge October 11, 2021 08:06
@mchammer01 mchammer01 added the ready to merge This pull request is ready to merge label Oct 11, 2021
@mchammer01 mchammer01 closed this Oct 11, 2021
auto-merge was automatically disabled October 11, 2021 08:45

Pull request was closed

@mchammer01 mchammer01 reopened this Oct 11, 2021
@mchammer01 mchammer01 enabled auto-merge October 11, 2021 08:45
@ramyaparimi ramyaparimi removed the waiting for review Issue/PR is waiting for a writer's review label Oct 11, 2021
@mchammer01 mchammer01 merged commit 96c5db8 into github:main Oct 13, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix an incorrect alt attribute in creating-a-pull-request.md

5 participants