-
Notifications
You must be signed in to change notification settings - Fork 64.4k
Fix an incorrect alt attribute for the codespaces-commit-pr.png image #10935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an incorrect alt attribute for the codespaces-commit-pr.png image #10935
Conversation
Excuse me, Ma'am or Sir? |
|
@lupinitylabs |
Jassi10000-zz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lupinitylabs Buddy I guess Alt text are completely in hand of the docs maintainer and obvio they must have written this considering some pts.
Thanks for your contributions but am afraid it may be not be considered or termed as invalid
You can look out for some other nice issues to contribute to
All the best!!!
|
@Jassi10000 I just encountered this when working on something else and I don't know why someone would want the same alt text for two completely different images, considering the alt should help robots to index and screenreaders to describe what's going on in the picture. In the end, it's just a pointer towards a potential issue. If you don't need it, no offense taken 😉 |
mchammer01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
Pull request was closed
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes #10934
What's being changed:
This PR fixes a copy & paste error for the alt text for
/assets/images/help/codespaces/codespaces-commit-pr.png, which seems to be copied from/assets/images/help/codespaces/codespaces-commit-pr-button.png.It changes the previous alt text of
Source control side bar with staging button highlightedtoGitHub pull request side bar, which more accurately describes the content of the screenshot.Check off the following:
Writer impact (This section is for GitHub staff members only):