Skip to content

Add webhook_active to GitHub App configuration parameters#11533

Merged
ramyaparimi merged 3 commits intogithub:mainfrom
steffen:patch-2
Nov 18, 2021
Merged

Add webhook_active to GitHub App configuration parameters#11533
ramyaparimi merged 3 commits intogithub:mainfrom
steffen:patch-2

Conversation

@steffen
Copy link
Copy Markdown
Contributor

@steffen steffen commented Oct 29, 2021

Why:

The webhook_active GitHub App configuration parameter is not documented.

What's being changed:

Added webhook_active to list of GitHub App configuration parameters in documentation.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Oct 29, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Oct 29, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 29, 2021

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/developers/apps/building-github-apps/creating-a-github-app-using-url-parameters.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 29, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@steffen
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@steffen
Copy link
Copy Markdown
Contributor Author

steffen commented Oct 29, 2021

@steffen Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi Thank you! Any idea why https://docs-11533--patch-2.herokuapp.com/developers/apps/building-github-apps/creating-a-github-app-using-url-parameters is not working?

image

@ramyaparimi
Copy link
Copy Markdown
Contributor

@steffen the staging deploys are temporarily on hold 💖

@lee-dohm lee-dohm self-assigned this Nov 10, 2021
Copy link
Copy Markdown
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Nov 17, 2021
@ramyaparimi ramyaparimi merged commit ae6cd67 into github:main Nov 18, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants