Skip to content

Fix link to self-review#11572

Merged
ramyaparimi merged 2 commits intogithub:mainfrom
miyajan:patch-3
Nov 4, 2021
Merged

Fix link to self-review#11572
ramyaparimi merged 2 commits intogithub:mainfrom
miyajan:patch-3

Conversation

@miyajan
Copy link
Copy Markdown
Contributor

@miyajan miyajan commented Nov 1, 2021

Why:

This issue was fixed by #10620, but was reverted by #11353.

What's being changed:

Fix the link to the self-review document in the PR template.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@miyajan miyajan requested a review from a team as a code owner November 1, 2021 04:19
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Nov 1, 2021
Copy link
Copy Markdown
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miyajan
Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@ramyaparimi ramyaparimi added ready to merge This pull request is ready to merge content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Nov 1, 2021
Copy link
Copy Markdown
Contributor

@TarunavBA TarunavBA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one @miyajan

@heiskr heiskr removed the request for review from a team November 1, 2021 15:31
@ramyaparimi ramyaparimi enabled auto-merge November 4, 2021 17:46
@ramyaparimi ramyaparimi merged commit aa6f7aa into github:main Nov 4, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 4, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants