Add note that secret scanning endpoints should be able to handle larg…#1219
Merged
shati-patel merged 2 commits intomainfrom Nov 16, 2020
Merged
Add note that secret scanning endpoints should be able to handle larg…#1219shati-patel merged 2 commits intomainfrom
shati-patel merged 2 commits intomainfrom
Conversation
…e number of matches without timing out
Contributor
|
Thanks @greysteil! I'll get this triaged for review ✨ |
janiceilene
added
content
twistedsoul59
approved these changes
Nov 12, 2020
shati-patel
approved these changes
Nov 16, 2020
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks, I'll get this merged! 🚢
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We occasionally see timeouts from our secret scanning partners when we sent them payloads with a large number of matches. This suggests that their endpoints process these matches during the request/response cycle.
What's being changed:
This PR contains a small addition to our documentation that hints that partner endpoints must be able to handle large numbers of matches in a single payload.
Check off the following: