Skip to content

Update about-forks.md#12313

Merged
ramyaparimi merged 4 commits intogithub:mainfrom
mnaderian:patch-2
Nov 29, 2021
Merged

Update about-forks.md#12313
ramyaparimi merged 4 commits intogithub:mainfrom
mnaderian:patch-2

Conversation

@mnaderian
Copy link
Copy Markdown
Contributor

@mnaderian mnaderian commented Nov 24, 2021 •
edited
Loading

Did not really understand the sentence where I made changes in so I thought maybe it was mistyped.

@welcome
Copy link
Copy Markdown

welcome Bot commented Nov 24, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Nov 24, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 24, 2021 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks.md Modified Original

ejcheng
ejcheng reviewed Nov 24, 2021
View reviewed changes
Comment thread content/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks.md Outdated
@mnaderian @ejcheng
Update content/pull-requests/collaborating-with-pull-requests/working…
b608494 
…-with-forks/about-forks.md

Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
@ejcheng
Copy link
Copy Markdown
Contributor

ejcheng commented Nov 25, 2021

LGTM! This repo doesn't let me send an approving review, weird...

ramyaparimi
ramyaparimi approved these changes Nov 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnaderian
Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Nov 29, 2021
@ramyaparimi ramyaparimi merged commit 5056189 into github:main Nov 29, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 29, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@mnaderian mnaderian deleted the patch-2 branch November 30, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ejcheng ejcheng ejcheng left review comments

@ramyaparimi ramyaparimi ramyaparimi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnaderian @ejcheng @ramyaparimi