Removed deprecated echo set-env instruction for python code scanning excerpt#1637
Merged
shati-patel merged 3 commits intogithub:mainfrom Dec 1, 2020
Merged
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
@AntoineRondelet Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
shati-patel
approved these changes
Dec 1, 2020
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Thank you so much for the fix @AntoineRondelet! I can confirm this is the correct syntax 🎉
I'll get your pull request merged shortly 😊
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
While trying to set up code scanning on a python code base, I followed the workflow extract https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#analyzing-python-dependencies, however, I got the following error while trying to execute it:
After consulting the link provided, and after reading: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files it seemed that the documentation was outdated (switching to
echo "CODEQL_PYTHON=$(which python)" >> $GITHUB_ENVseems to resolve the issue on my end)What's being changed:
As mentioned above, this PR changes:
echo "::set-env name=CODEQL_PYTHON::$(which python)"toecho "CODEQL_PYTHON=$(which python)" >> $GITHUB_ENVFollowing https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ and https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files
Check off the following: