-
Notifications
You must be signed in to change notification settings - Fork 64.8k
Update steps to create repo secrets #18175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for submitting a PR to the GitHub Docs project! In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request. fpt: Free, Pro, Team |
|
@thispsj Thanks so much for opening a PR! I'll get this triaged for review ✨ |
|
I'll review this and need to check the behavior on GHES 3.3, 3.4 and 3.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thispsj 👋🏻 - thanks for your contribution ✨
I've made some suggestions as I tested the behavior on dotcom, GHES 3.3, GHES 3.4 and GHES 3.5.
I'd like to edit the {% data reusables.actions.sidebar-secret %} reusable (found in data/reusables/dependabot/dependabot-secrets-button) but I wasn't able to fetch your branch and add a commit.
I'd like to edit it so it contains the following:
{% ifversion fpt or ghec or ghes > 3.2 or ghae-issue-5658 %}
1. Inside the "Secrets" section of the sidebar, click **{% data variables.product.prodname_dependabot %}**.

{% endif %}
Can you help with that? (Not sure why I can't get your branch). Thanks!
...ode-security/dependabot/working-with-dependabot/managing-encrypted-secrets-for-dependabot.md
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
|
{% data reusables.actions.sidebar-secret %} is used in 4 files:
1 and 2 relate to Actions, 3 to Dependabot and 4 to Codespaces. @thispsj 👋🏻 - so my recommendation would be to: A- Update {% data reusables.actions.sidebar-secret %} so that it mentions clicking "Actions" inside "Secrets" (like you initially did in this PR). This takes care of 1 and 2. We can no longer use this reusable for 3 and 4 as it now specifically mentions Actions. B. Add 2 new reusables, one in What do you think? Do you feel comfortable with implementing this? |
|
@mchammer01 ya absolutely comfortable. |
|
@thispsj 👋🏻 - I'm going to be away for a few days so once your new updates are ready, would you mind re-adding the |
|
Hi @mchammer01 , What if I put these changes right now ? |
|
@janiceilene / @cmwilson21 - could you put this up for review once @thispsj has made the suggested changes? Thank youuu 🙇🏻 😄 |
|
@mchammer01 good idea, I'll just tag one of them once I'm done. |
Will rename the present reusable to this in next commit
|
@cmwilson21 👋 |
Vana12330
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0x8463a980e5b1fe116df96f8672dae9934b131cb5
Resolved conflicts in secret reusable data/reusables/actions/sidebar-secret.md
lucascosti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this one! I've resolved the conflicts and all looks good. I'll get this merged! 🚀
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
@lucascosti no problem 🙂 |
Why:
Closes #17791
What's being changed:
Everything mentioned by @github-actions in Content Changes table. In Dependabot article, removed one step which was not needed.
233604b - Updated the reusable to the latest steps
Check off the following: