Skip to content

fix: add discussions to contribution graph#1957

Merged
hubwriter merged 2 commits intogithub:mainfrom
iam-frankqiu:fix_contributions
Jan 7, 2021
Merged

fix: add discussions to contribution graph#1957
hubwriter merged 2 commits intogithub:mainfrom
iam-frankqiu:fix_contributions

Conversation

@iam-frankqiu
Copy link
Copy Markdown
Contributor

Why:

Actually. When I created a discussion. It will be counted on my contribution graph. So, I think this is a bug.

What's being changed:

Add discussions to the contribution graph.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link
Copy Markdown

welcome Bot commented Dec 10, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Dec 10, 2020
@janiceilene
Copy link
Copy Markdown
Contributor

Thanks so much for opening a PR! I'll get this triaged for review ✨

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Dec 17, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 17, 2020
@janiceilene
Copy link
Copy Markdown
Contributor

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@iam-frankqiu
Copy link
Copy Markdown
Contributor Author

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

Thank you for your comment!

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Dec 25, 2020
@iam-frankqiu
Copy link
Copy Markdown
Contributor Author

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

Staled again?

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 28, 2020
@janiceilene
Copy link
Copy Markdown
Contributor

Sorry about that @iam-frankqiu! Between GitHub Universe and the holidays, we're backed up on reviews right now 💛

@iam-frankqiu
Copy link
Copy Markdown
Contributor Author

Sorry about that @iam-frankqiu! Between GitHub Universe and the holidays, we're backed up on reviews right now 💛

Thank you.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Jan 5, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 5, 2021
@hubwriter hubwriter self-assigned this Jan 7, 2021
@hubwriter
Copy link
Copy Markdown
Contributor

Hi @iam-frankqiu - Thanks for raising this PR. Apologies for the delay reviewing it.

I just created a Discussion to check this out and it didn't show up on my contribution graph. I'm going to run this by the Discussions team to get their confirmation. I'll update this PR after I hear back from them.

In the meantime thanks again for contributing. 👍

@iam-frankqiu
Copy link
Copy Markdown
Contributor Author

I just created a Discussion to check this out and it didn't show up on my contribution graph. I'm going to run this by the Discussions team to get their confirmation. I'll update this PR after I hear back from them.

You are welcome! It may have a 24hours delay for the contribution graph.
https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-profile/why-are-my-contributions-not-showing-up-on-my-profile#common-reasons-that-contributions-are-not-counted

Copy link
Copy Markdown
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iam-frankqiu - our Discussions folks have got back to me. You're right, and your change is a good one. Many thanks.

I had created a team discussion post, not a discussion, which is why my contribution graph didn't change.

@hubwriter
Copy link
Copy Markdown
Contributor

Merging this now.

@iam-frankqiu - thanks again for contributing ... and for your patience! 😃

@hubwriter hubwriter merged commit 54190f2 into github:main Jan 7, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants