Fix filter pattern cheat sheet examples #1994

tomjschuster · 2020-12-11T02:39:37Z

Why:

fixes #855

In the Filter pattern cheat sheet examples section of https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet:

Regex example for matching any number or lowercase letter is shown incorrectly as [0-9a-f] (any hexadecimal number)
Examples of patterns to match different paths are prepended with -, but because they are within table cells, they are shown as literal -'s instead of bullet points. Since many of the patterns actually include -, this is visually confusing.

What's being changed:

Correct the regex pattern for numbers/lowercase letters to [0-9a-z]
Remove the - before the pattern examples in the table cells (line breaks should be sufficient for separating the patterns)

Check off the following:

All of the tests are passing.
I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
For content changes, I have reviewed the localization checklist
For content changes, I have reviewed the Content style guide for GitHub Docs.

tomjschuster · 2020-12-11T03:01:27Z

content/actions/reference/workflow-syntax-for-github-actions.md

-| `'*feature'` | The `*` character is a special character in YAML. When you start a pattern with `*`, you must use quotes. | -`mona-feature`<br/>-`feature`<br/>-`ver-10-feature` |
-| `v2*` | Matches branch and tag names that start with `v2`. | -`v2`<br/>-`v2.0`<br/>-`v2.9` |
-| `v[12].[0-9]+.[0-9]+` | Matches all semantic versioning tags with major version 1 or 2 | -`v1.10.1`<br/>-`v2.0.0` |
+| `feature/*` | The `*` wildcard matches any character, but does not match slash (`/`). |  `feature/my-branch`<br/><br/>`feature/your-branch` |


Adding an additional line break to make the separation clearer:
1 line break: 👇

2 line breaks: 👇

janiceilene · 2020-12-11T17:06:14Z

@tomjschuster Thanks so much for opening a PR! I'll get this triaged for review ⚡

github-actions · 2020-12-18T17:17:03Z

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

janiceilene · 2020-12-18T17:24:16Z

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

github-actions · 2020-12-25T17:26:12Z

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

tomjschuster · 2020-12-26T20:58:39Z

Just commenting to keep this open. Hope everyone is enjoying their holidays.

github-actions · 2021-01-03T17:37:40Z

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

skedwards88

This looks great! Thank you for fixing these issues.

github-actions · 2021-01-05T00:46:02Z

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@imjohnbo

* Remove unnecessary word / typo (github#17007) Fixes https://github.com/github/docs-content/issues/3097 Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com> Co-authored-by: Laura Coursen <lecoursen@github.com> * Update landing pages with recent changelog updates (github#16946) * add actions changelog items * update packages changelogs * Make the repo sync stall check less aggressive (github#17018) Co-authored-by: chiedo <chiedo@users.noreply.github.com> * Remove mention of GraphQL API rate limit increases for GHEC organizations (github#17006) * Section on rate limits should not be nested within section on node limits since those are separate limits * Remove mention of GraphQL API rate limit increases for GHEC orgs Fixes https://github.com/github/docs-content/issues/3474 Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com> * reenable graphql updater (github#16994) * re-enable graphql updater workflow * remove scheduled run temporarily * lint yaml * re-enable graphql updater workflow * add my pat for test * use my pat for create pr * update peter-evans action * Action ran graphql script"update-files" * use github-token * revert * Action ran graphql script"update-files" (#17000) * update another workflow * add schedule run back Co-authored-by: rachmari <rachmari@users.noreply.github.com> Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Add Amazon ECS guide * Add Azure App Service guide * Add links to guides * Fix versioning for "GitHub Insights and data protection for your organization" * Marketplace should be dotcom-only * redirect from Enterprise versions of the page * support hardcoded versions in frontmatter redirects * Remove duplicated items * Update content/actions/guides/deploying-to-azure-app-service.md * Update guidelines-for-legal-requests-of-user-data.md (github#16756) Remove legal@support.github.com email address from legal request guidelines Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> * change external /contact link to contact variable * do more path checking * Revise intro sentence per @imjohnbo's suggestion * GKE article edits for lists * Added edits and style changes to Amazon guide * Added edits and style changes to Azure web app guide * Replace pseudo environment variables with obvious replaceables in examples * Fix bad link URL * fix double slash typo in links * updates for clarity * Remove DE language from staging (github#17038) Co-authored-by: chiedo <chiedo@users.noreply.github.com> * Remove DataDog from Staging (github#17036) Remove DataDog from staging Co-authored-by: chiedo <chiedo@users.noreply.github.com> * add some clarifying comments * borrow initial findPage lookup from github#16965 * Code scanning docs: small fixes (github#17035) * update branch when out of date (github#17031) * update branch when out of date * small copy update * var rename * lint yaml * the new map topic handling now needs context.currentPath * we need to use a regex so we can be sure we are removing the final segment of the path... apparently this is still faster than a split/slice/join * try to make this check as fast as we can * Changes to Code Search & what data stays in the index (github#16882) * Update searching-code.md * Update searching-code.md Change only applies to github.com not GHES. Co-authored-by: Laura Coursen <lecoursen@github.com> * lint * Update mention in contributing (github#17045) * add missing redirect frontmatter (github#17042) Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com> * fix repo-sync bug (github#17047) * fix repo-sync bug * add another log * add mergeable_state check * check for pull number * add check for prior steps * remove test logs * lint * Fix load site data reporting wrong timing data (github#17050) * Block indexing not crawling (github#17044) * Block indexing instead of crawling * Lint * Update deprecated-enterprise-versions.js * Combine loops * Update content/actions/guides/deploying-to-amazon-elastic-container-service.md Co-authored-by: Steve Winton <swinton@github.com> * Update content/actions/guides/deploying-to-amazon-elastic-container-service.md Co-authored-by: Steve Winton <swinton@github.com> * Update content/actions/guides/deploying-to-amazon-elastic-container-service.md * Add new patch notes (github#17059) * Update events-that-trigger-workflows.md (github#17013) Co-authored-by: skedwards88 <skedwards88@github.com> Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> * remove extra lang codes * replace pageWithSwitcher article with one that does not have a default platform set * Hide content that overflows in search list (github#17066) * fix typo in creating-a-pull-request-from-a-fork.md * Cookie policy updates (github#16554) Co-authored-by: Peter Cihon <71285354+pcihon@users.noreply.github.com> Co-authored-by: hubwriter <hubwriter@github.com> Co-authored-by: Jenn DeForest <42984983+jenndeforest@users.noreply.github.com> Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> * Edit GHAE version for API header example (github#17056) * Update docs for generating a new SSH key for windows I was trying to add a ssh key to my github using windows 10, and i was uncapable to procceed. And i found that the commands `$ eval $(ssh-agent -s)` don't work on windows, but ` $ eval `ssh-agent -s` ` works fine * Add details of the Used by sidebar section (github#17058) Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> * npm versions limit (github#17030) * Add note about this * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Bryan Clark <clarkbw@github.com> * Apply suggestions from code review Co-authored-by: Bryan Clark <clarkbw@github.com> * Update team name (github#17075) * fix breadcrumbs block * Clarify container deletion (github#16576) * Revise deletion steps * tweak subheader * Fix all the ways to delete a container image with latest UI * Delete outdated step * Confirmed 6 different UI assortments * small tweak * ALT text * Add delete-container-package-version * Fluidity * Final edits * Updating OpenAPI descriptions (github#17076) * Updating OpenAPI descriptions * Add decorated OpenAPI schema files Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> * Updating OpenAPI descriptions (github#17077) * Updating OpenAPI descriptions * Add decorated OpenAPI schema files Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> * Updating OpenAPI descriptions (github#17079) * Updating OpenAPI descriptions * Add decorated OpenAPI schema files * Fix a few typos (github#16959) This fixes https://github.com/github/docs-content/issues/2769 Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com> Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> * fix typo in Gradle Kotlin DSL script filename extension * Update resources-in-the-rest-api.md (github#16981) Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> * remove "tests are passing" checkbox * Change the wording I suggest changing the wording of this sentence "The formatting of a field is invalid. Review the documentation for the for more specific information." so that it would read "The formatting of a field is invalid. Review the documentation for more specific information". * Updating OpenAPI descriptions (github#17089) * Updating OpenAPI descriptions * Add decorated OpenAPI schema files * Fix broken links (github#17081) * Fix two broken links * Update content/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests.md Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> * fix typo in Differences between GitHub apps and OAuth apps * Fix typo in Setting repository visibility * Hide ToC items with `hidden` (github#17107) * Update github-subprocessors-and-cookies.md (github#17110) Remove subprocessor from list cc: @MayHK * removed the about-labels masked link. Reason: Link redirects to the current page, not needed * Update github-marketplace-developer-agreement.md (github#16710) Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> * Added a note about debugging, added intro text. * Apply suggestions from code review Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> * Minor spelling corrections * [January 4, 2021] Marketplace revenue change (github#16792) * Move changes to revenue into new PR * Minor text changes for revised publication date * Update content/developers/github-marketplace/receiving-payment-for-app-purchases.md Co-authored-by: Laura Coursen <lecoursen@github.com> * Clarify revenue change dates Co-authored-by: Laura Coursen <lecoursen@github.com> Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> * Update testing-your-ssh-connection.md (github#2220) * Update testing-your-ssh-connection.md The edited language was confusing and incorrect. See https://github.community/t/ssh-fingerprint-matching-issue/150693 * Avoid hardcoded github.com domain in docs link PR won't pass required tests without this change. Co-authored-by: hubwriter <hubwriter@github.com> * Add information about management of an enterprise to "About enterprise accounts" article for GitHub AE and GitHub Enterprise Server (github#16818) * Add links to information about enterprise management * Address Laura's feedback * Remove link to page not in GHES/GHAE (github#17122) * Remove link to page not in GHES/GHAE * Update content/github/authenticating-to-github/testing-your-ssh-connection.md Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> * Update content/developers/apps/creating-a-github-app-from-a-manifest.md * Revert broken translated files to english (github#17126) * Fix invalid syntax for pull_request_target example (github#1890) Co-authored-by: Sarah Edwards <skedwards88@github.com> * Fix filter pattern cheat sheet examples (github#1994) * Fix filter pattern cheat sheet examples * Add additional line break between patterns Co-authored-by: Sarah Edwards <skedwards88@github.com> * Fix command block rendering with raw tags (#17136) * Add troubleshooting for HEAD analysis warning (github#17121) * Dependabot: clarify info about dependency inaccessibility (github#17032) * Clarify info about dependency inaccessibility See issue raised by Maya K https://github.com/github/docs-internal/issues/16786 * Update data/reusables/dependabot/private-dependencies-note.md Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com> Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com> * Make Repo Sync Stall Workflow check for the automated-repo-sync label (github#17142) Currently the Repo Sync Stall checker is including PRs that aren't repo sync PRs. This change should ensure that is no longer the case Co-authored-by: chiedo <chiedo@users.noreply.github.com> Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com> * Patch (github#17144) Co-authored-by: chiedo <chiedo@users.noreply.github.com> * Fix some typos in the lib directory (github#17131) Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com> * Fix a bunch of random typos (github#17129) Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com> * Fix a bunch of typos in tests dir (github#17132) Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com> * Fix a few typos in content dir (github#17133) Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com> * environments supported on enterprise (github#17127) * Parentheticals -> parentheses (github#17130) * Update trade controls FAQ (#17137) * updates to trade controls Made updates to the trade controls FAQ to support the 1/5 launch. * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Mike Linksvayer <mlinksva@github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Mike Linksvayer <mlinksva@github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Mike Linksvayer <mlinksva@github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Lynn Hashimoto <lyhashim@github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Lynn Hashimoto <lyhashim@github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Lynn Hashimoto <lyhashim@github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Lynn Hashimoto <lyhashim@github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Lynn Hashimoto <lyhashim@github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Lynn Hashimoto <lyhashim@github.com> * Update content/github/site-policy/github-and-trade-controls.md * incorporate overview changes this commit incorporates the changes made to the overview section. cc @lyhashim for 👀 * Update content/github/site-policy/github-and-trade-controls.md Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> Co-authored-by: Mike Linksvayer <mlinksva@github.com> Co-authored-by: Lynn Hashimoto <lyhashim@github.com> Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> * adding link to blog post * Update github-and-trade-controls.md * Crowdin translations (github#17143) * New Crowdin translations by Github Action * Revert broken translated files to english * fix dates * fix translation 😭 Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com> Co-authored-by: Ivan Žužak <izuzak@gmail.com> Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com> Co-authored-by: Laura Coursen <lecoursen@github.com> Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com> Co-authored-by: chiedo <chiedo@users.noreply.github.com> Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com> Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com> Co-authored-by: Rachael Sewell <rachmari@github.com> Co-authored-by: rachmari <rachmari@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Steve Winton <stevewinton@gmail.com> Co-authored-by: Sarah Schneider <sarahs@github.com> Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com> Co-authored-by: Jenn DeForest <42984983+jenndeforest@users.noreply.github.com> Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com> Co-authored-by: Rimas Silkaitis <neovintage@github.com> Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com> Co-authored-by: Steve Winton <swinton@github.com> Co-authored-by: Jason Etcovitch <jasonetco@github.com> Co-authored-by: Jaroslav Lobačevski <jarlob@github.com> Co-authored-by: skedwards88 <skedwards88@github.com> Co-authored-by: lemonez <36384768+lemonez@users.noreply.github.com> Co-authored-by: May Haim Kotlarsky <mayHK@github.com> Co-authored-by: Peter Cihon <71285354+pcihon@users.noreply.github.com> Co-authored-by: hubwriter <hubwriter@github.com> Co-authored-by: William Torres <contatowilliamtorres@gmail.com> Co-authored-by: Janice <janiceilene@github.com> Co-authored-by: Bryan Clark <clarkbw@github.com> Co-authored-by: Arhell <arhell333@gmail.com> Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com> Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Co-authored-by: Tammy Metz <tmetz@github.com> Co-authored-by: Daria <76159502+dariluka@users.noreply.github.com> Co-authored-by: gsonly <gsonly.imo@gmail.com> Co-authored-by: Plato <platoo@outlook.it> Co-authored-by: Dhruvin-Purohit <73269605+Dhruvin-Purohit@users.noreply.github.com> Co-authored-by: Jae Pak <59985282+jaepak20@users.noreply.github.com> Co-authored-by: Martin Lopes <martin389@github.com> Co-authored-by: Lucas Alves <lcsjalves@gmail.com> Co-authored-by: Felicity Chapman <felicitymay@github.com> Co-authored-by: Charles Curley <charlescurley@users.noreply.github.com> Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com> Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com> Co-authored-by: Tom Schuster <tomjschuster@gmail.com> Co-authored-by: Maya Kaczorowski <15946341+mayakacz@users.noreply.github.com> Co-authored-by: Kathy Korevec <simpsoka@github.com> Co-authored-by: Mike Linksvayer <mlinksva@github.com> Co-authored-by: Lynn Hashimoto <lyhashim@github.com> Co-authored-by: Samantha Chau <62048000+samanthachau@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

tomjschuster added 2 commits December 10, 2020 21:30

Fix filter pattern cheat sheet examples

500922b

Add additional line break between patterns

99ad9fc

tomjschuster commented Dec 11, 2020

View reviewed changes

SMAKSS approved these changes Dec 11, 2020

View reviewed changes

janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 11, 2020

github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 18, 2020

janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 18, 2020

github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 25, 2020

github-actions bot removed the stale There is no recent activity on this issue or pull request label Dec 27, 2020

github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 3, 2021

janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 4, 2021

skedwards88 approved these changes Jan 5, 2021

View reviewed changes

skedwards88 added the ready to merge This pull request is ready to merge label Jan 5, 2021

Merge branch 'main' into patch-2

f4beeb6

skedwards88 merged commit 4629901 into github:main Jan 5, 2021

sisamiul mentioned this pull request Mar 28, 2024

[Snyk] Upgrade @primer/css from 19.4.0 to 19.8.2 sisamiul/docs#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix filter pattern cheat sheet examples #1994

Fix filter pattern cheat sheet examples #1994

Uh oh!

tomjschuster commented Dec 11, 2020 •

edited

Loading

Uh oh!

tomjschuster Dec 11, 2020

Uh oh!

janiceilene commented Dec 11, 2020

Uh oh!

github-actions bot commented Dec 18, 2020

Uh oh!

janiceilene commented Dec 18, 2020

Uh oh!

github-actions bot commented Dec 25, 2020

Uh oh!

tomjschuster commented Dec 26, 2020

Uh oh!

github-actions bot commented Jan 3, 2021

Uh oh!

skedwards88 left a comment

Uh oh!

github-actions bot commented Jan 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix filter pattern cheat sheet examples #1994

Fix filter pattern cheat sheet examples #1994

Uh oh!

Conversation

tomjschuster commented Dec 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why:

What's being changed:

Check off the following:

Uh oh!

tomjschuster Dec 11, 2020

Choose a reason for hiding this comment

Uh oh!

janiceilene commented Dec 11, 2020

Uh oh!

github-actions bot commented Dec 18, 2020

Uh oh!

janiceilene commented Dec 18, 2020

Uh oh!

github-actions bot commented Dec 25, 2020

Uh oh!

tomjschuster commented Dec 26, 2020

Uh oh!

github-actions bot commented Jan 3, 2021

Uh oh!

skedwards88 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tomjschuster commented Dec 11, 2020 •

edited

Loading